Fix for k8s.io/[email protected] #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runakash
force-pushed
the
fix-apimachinery-api-for-coredns-193
branch
from
192b845 to
dc68c30
Compare
chrisohaver
requested changes
Aug 3, 2022
Makes sense. Seems like it will be simpler to onboard go module. What do you think? |
Simpler than not deleting two functions? Maybe I'm not seeing the whole picture. |
runakash
force-pushed
the
fix-apimachinery-api-for-coredns-193
branch
2 times, most recently
from
123b3bc to
d296d03
Compare
…ame/SetZZZ_DeprecatedClusterName. Signed-off-by: Akash Rungta <[email protected]>
runakash
force-pushed
the
fix-apimachinery-api-for-coredns-193
branch
from
d296d03 to
215c3b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9