Perhaps use heroku-deflater

[jdossett]

It looks like we may be double compressing some of our content by using Rack::deflater, perhaps we can use heroku-deflater it includes the functionality of heroku-rails-deflate, but is actually actively maintained.

[david-a-wheeler]

Note that this is related to #575, where we gave up on heroku_rails_deflate.

[david-a-wheeler]

Hmm, there are issues claiming that the functionality we want is already in Rails and Rack::Deflator:

• interaction with rails serving .gz files romanbsd/heroku-deflater#32 - detection and use of pre-existing .gz
• Rack::Deflater already has this functionality? romanbsd/heroku-deflater#33 - compressing HTML but not images etc.

Perhaps we should double-check to see if we're actually re-compressing static assets in production. It may already be there, in which case we may be a victim of poor/obsolete documentation.

[david-a-wheeler]

I did a little digging on this gem. I'm glad it's maintained, but the issues leave me a little pause:
https://github.com/romanbsd/heroku-deflater/issues

We need double-check & see if we're actually recompressing compressed items. It may no longer be needed in our case.

[jdossett]

I am going to close this now, what we have is working well enough that we shouldn't need to add this.

[dankohn]

Please also delete these lines: https://github.com/coreinfrastructure/best-practices-badge/blob/master/Gemfile#L98-L102

…

On Sun, Jun 18, 2017 at 6:32 PM, Jason Dossett ***@***.***> wrote: Closed #721 <#721>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#721 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC8MBj9GeuDRKDNU0N0drjYhdST1KAPYks5sFaWagaJpZM4MsMSL> .

-- Dan Kohn <mailto:[email protected]> Executive Director, Cloud Native Computing Foundation <https://cncf.io/> tel:+1-415-233-1000

[jdossett]

Done.

[dankohn]

I loved that Rubocop failure. Most pedantic build fail ever.

…

On Sun, Jun 18, 2017 at 8:51 PM, Jason Dossett ***@***.***> wrote: Done. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#721 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC8MBh-cfRN1x637indCxnAz0uxMAnLoks5sFcYlgaJpZM4MsMSL> .

-- Dan Kohn <mailto:[email protected]> Executive Director, Cloud Native Computing Foundation <https://cncf.io/> tel:+1-415-233-1000