Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] smarter way to identify overlapping storage regions #146

Open
bchess opened this issue Jun 27, 2024 · 0 comments
Open

[3.0] smarter way to identify overlapping storage regions #146

bchess opened this issue Jun 27, 2024 · 0 comments
Assignees

Comments

@bchess
Copy link
Contributor

bchess commented Jun 27, 2024

Eta0 last week
Interestingly, PyTorch counts tensors imported from other libraries like numpy as always having separate storages, even if they overlap or represent a completely identical region when compared with other storages—even in its Tensor.is_set_to function, so non-PyTorch-native tensors are sort of a "known bug" for this method, though it's niche enough to not affect almost any normal workflows.

Other than that, we can identify overlapping input data more precisely using an O(n⋅log⁡(n)) (where n is the number of tensors) algorithm I designed for it once, since this old way incorrectly identifies disjoint slices of a tensor as being shared, but we can add that in another PR, since it's not a regression of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants