Rename the confusing operator field to subRequirementProgress #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 385. |
|
Visit the preview URL for this PR (updated for commit 4802aeb): https://cornelldti-courseplan-dev--pr265-operator-to-subrequi-a4beu1nx.web.app (expires Tue, 16 Feb 2021 02:30:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
tcho6319
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #138. This PR addresses the first and final unresolved issue in that github issue. The
operator: 'and' | 'or'is very confusingly named and every time it took me a while to understand what they mean. This PR changes them tosubRequirementProgress: 'every-course-needed' | 'any-can-count'I believe this wording can make the code reader know just be reading that this field tells how subrequirement progress stat is computed.
Test Plan
All requirements are computed as usual: