Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Requirements Handling] Add to the 120 credits on repeated courses #141

Closed
handotdev opened this issue Sep 24, 2020 · 0 comments · Fixed by #280
Closed

[Requirements Handling] Add to the 120 credits on repeated courses #141

handotdev opened this issue Sep 24, 2020 · 0 comments · Fixed by #280

Comments

@handotdev
Copy link
Member

According to the university's information on the credits, the number of the total academic requirements needed increases for repeated courses.

Screen Shot 2020-09-24 at 11 33 32 AM
SamChou19815 added a commit that referenced this issue Feb 12, 2021
@SamChou19815
Add to the 120 credits on repeated courses
291307b 
Resolve #141.

Implemented according to my proposal during the meeting:

- Lifting the total credits requirement out of the generated requirement json and special case it on frontend
- As a result, it will not become part of requirement graph as desired.
- In addition, the requirement json dropped from 2.5M to 800k!
@SamChou19815 SamChou19815 mentioned this issue Feb 12, 2021
Merged
SamChou19815 added a commit that referenced this issue Feb 12, 2021
@SamChou19815
Add to the 120 credits on repeated courses
87fc51d 
Resolve #141.

Implemented according to my proposal during the meeting:

- Lifting the total credits requirement out of the generated requirement json and special case it on frontend
- As a result, it will not become part of requirement graph as desired.
- In addition, the requirement json dropped from 2.5M to 800k!
SamChou19815 added a commit that referenced this issue Feb 13, 2021
@SamChou19815
Add to the 120 credits on repeated courses (#280)
b40f7cb 
* Add to the 120 credits on repeated courses

Resolve #141.

Implemented according to my proposal during the meeting:

- Lifting the total credits requirement out of the generated requirement json and special case it on frontend
- As a result, it will not become part of requirement graph as desired.
- In addition, the requirement json dropped from 2.5M to 800k!

* Fix spacing and periods

* Handle min count increase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add to the 120 credits on repeated courses cornell-dti/course-plan
1 participant
@handotdev