[EZ Bug Fix] Close onboarding bug #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 4. |
|
Visit the preview URL for this PR (updated for commit 1030e63): https://cornelldti-courseplan-dev--pr403-close-onboarding-bug-taummq3d.web.app (expires Sun, 04 Apr 2021 22:33:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
SamChou19815
approved these changes
Mar 28, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When you haven't submitted your data for onboarding you shouldn't be able to close out of the onboarding modal.
My previous version of this fix wasn't right. I had to check the global onboardingData and not the local (not saved) fields from the onboarding form.
Test Plan