Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect courseplan AP credit logic #397

Closed
abcdefguan opened this issue Mar 27, 2021 · 9 comments · Fixed by #411
Closed

Incorrect courseplan AP credit logic #397

abcdefguan opened this issue Mar 27, 2021 · 9 comments · Fixed by #411

Comments

@abcdefguan
Copy link

abcdefguan commented Mar 27, 2021

My AP credit is not carried over correctly. See [email protected] 's account

I input that I have AP credit for:
AP Physics C E&M
AP Physics C Mechanics

These provide AP credit for PHYS 1112 and PHYS 2213

However, my dashboard says that I have not fulfilled any physics courses and need to take PHYS 1112 and PHYS 2213

The same problem occurs for chemistry and mathematics, but I took A level chemistry and got credit for those so I'm not sure how it should work exactly. I did indicate I took the placement test for chemistry and mathematics though

@SamChou19815 SamChou19815 changed the title Incorrect courseplan logic Incorrect courseplan AP credit logic Mar 29, 2021
@tcho6319
Copy link
Collaborator

tcho6319 commented Mar 31, 2021

AP Physics C Mechanics does not seem to be applied to PHYS 1112 still. @benjamin-shen and @hahnbeelee

@tcho6319 tcho6319 reopened this Mar 31, 2021
@abcdefguan
Copy link
Author

Issue still not fixed:

AP Microeconomics should be counted as liberal studies
AP Physics C Mechanics should be counted as equivalent of PHYS 1112

@SamChou19815
Copy link
Contributor

Both seem to work for me?

Screen Shot 2021-03-31 at 11 03 38

Screen Shot 2021-03-31 at 11 05 09

@abcdefguan
Copy link
Author

AP Macroeconomics is working for me, but AP Microeconomics is not. AP Physics C Mechanics is not working.
Screenshot from 2021-03-31 11-36-48

@tcho6319
Copy link
Collaborator

Yes same here. I'm getting the same issue when I replicated the AP exam data that Guan has

@SamChou19815
Copy link
Contributor

Problem confirmed... The core requirement graph algorithm just doesn't like the two courses with the same uniqueId get assigned to the same requirement... This happens to be the case for AP/IB credit where all the unique ID is hardcoded to -1...

@SamChou19815
Copy link
Contributor

Fix for the physics AP credit is coming in #417.
The macro/micro economics one might still depend on engineering liberal arts requirement fix.

@SamChou19815
Copy link
Contributor

Confirmed that the macroecon and microecon AP can also be used to fulfill now. Now all problems are resolved so i'm going to close the issue.

@abcdefguan
Copy link
Author

Yes. It's working now. Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants