Unbreak AP/IB requirement computation #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 23. |
|
Visit the preview URL for this PR (updated for commit a2b4a97): https://cornelldti-courseplan-dev--pr411-unbreak-ap-ib-p3x30cjq.web.app (expires Wed, 07 Apr 2021 03:50:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
benjamin-shen
approved these changes
Mar 31, 2021
SamChou19815
force-pushed
the
unbreak-ap-ib
branch
from
15f347a to
a2b4a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This bug is introduced during my live coding session. In that change, I will remove all edges when there is no user choice associated with a unique ID. However, I forget to consider the case when all the AP/IB equivalent courses all have the same unique ID -1. If we do the same for AP/IB courses, then all these courses will never be able to fulfill anything.
Therefore, we must bail out when
uniqueID == -1.Test Plan
Added a regression test about this bug.
Notes
This change will fix #397.