Fix failing requirements sidebar Cypress test #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 8. |
|
Visit the preview URL for this PR (updated for commit c9144a7): https://cornelldti-courseplan-dev--pr697-fix-failing-test-qf1jrn7x.web.app (expires Wed, 06 Jul 2022 18:33:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
benjamin-shen
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes the requirements bar accessibility cypress test that ocassionally fails on master. This test opens all parts of the requirements sidebar before checking accessibility. However, it currently fails if there are no "Show completed" reqs toggle, which occurs when no courses are in the plan, which only happens sometimes depending on the order the tests were run. This PR adds the swim test course so that at least that one req will always be fulfilled.
Test Plan
Clear all courses on the testing account, and confirm the Cypress tests still pass.