-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cymbal choke causes rim triggers #111
Comments
Yes, this is true. I can see this with my Roland cymbal as well. But it is not noticeable during my normal playing. The choke detection in Edrumulus is delayed a bit. Therefore, you will have a similar issue like you had with the cross-talk cancellation. The invalid detected strike will be there before the choke is detected. Maybe you could try to suppress these MIDI notes with your Python script like you do with the cross-talk cancellation. Would be interesting to know if that works. |
Hm, I don't like to do things badly just because others do that, too.
I'll probably try to fix it with my cross-talk script.
|
Would be interesting to know how your Millenium brain performs in this situation. Do you see similar effects? |
This could partially be fixed via my script. Only partially as the first incorrect MIDI event happens ~10ms before the choke, the second ~5ms and I only want to delay events by at most 5ms, i.e. the first will continue to pass. In theory 10ms delay is supported though. |
Btw increasing the sense time helped with this issue. However it caused worse rim detection, so that I dropped the change again. |
Using the cymbal choke currently causes low volume rim triggers (usually two or so).
Also, holding the choke sometimes seems to just delay playback rather than stopping it. The latter may be a drumgizmo issue though.
The text was updated successfully, but these errors were encountered: