Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: dockerfiles simplification: add a way to copy files or binaries #597

Open
Anmol1696 opened this issue Jan 7, 2025 · 0 comments · May be fixed by #599
Open

feature: dockerfiles simplification: add a way to copy files or binaries #597

Anmol1696 opened this issue Jan 7, 2025 · 0 comments · May be fixed by #599

Comments

@Anmol1696
Copy link
Collaborator

Anmol1696 commented Jan 7, 2025 •
edited
Loading

Overview

We seem to have multiple docker images with very similaris dockerfiles as base with only difference in copying files from base images.

--- Dockerfile.eth-beacon
COPY --from=source /beacon-chain /usr/bin
--- Dockerfile.eth-prysmctl
COPY --from=source /prysmctl /usr/bin
--- Dockerfile.eth-validator
COPY --from=source /validator /usr/bin
---

Options 1

We can either define a copy in versions.yaml which is a list.

  - name: prysm/cmd/prysmctl
    base: gcr.io/prysmaticlabs/prysm/cmd/prysmctl
    file: Dockerfile.eth-prysmctl
    copy:
      - "/beacon-chain:/usr/bin"
    tags:
      - stable
      - v5.2.0

Options 2

  - name: prysm/cmd/prysmctl
    base: gcr.io/prysmaticlabs/prysm/cmd/prysmctl
    file: Dockerfile.eth-prysmctl
    copy:
      - src: "/beacon-chain"
        dst: "/usr/bin"
    tags:
      - stable
      - v5.2.0
@Anmol1696 Anmol1696 linked a pull request Jan 8, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: docker copy cosmology-tech/starship
1 participant
@Anmol1696