Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start of CLI #68

Closed
wants to merge 1 commit into from
Closed

start of CLI #68

wants to merge 1 commit into from

Conversation

dllussier
Copy link
Collaborator

This is not ready to be merged yet, just looking for initial feedback. This is the start of the CLI using argparse. Plans are to include the options to choose between load_confounds or niak_load_confounds, easier bash interface, options for model saving and output file, and improvement of file list implementation.

Feedback and suggestions welcome! Please do not merge this as is!

@dllussier
start of CLI
0cc506f 
This is not ready to be merged yet, just looking for initial feedback. This is the start of the CLI using argparse. Plans are to include the options to choose between load_confounds or niak_load_confounds, easier bash interface, options for model saving and output file, and improvement of file list implementation. 

Feedback and suggestions welcome! Please do not merge this as is!
@dllussier dllussier linked an issue May 7, 2020 that may be closed by this pull request
create a bash interface for dypac #53
Open
@pbellec
Copy link
Contributor

pbellec commented May 8, 2020

Looks excellent. I am not thrilled by the idea of adding a dependency on load_confounds, but it's not a huge deal. Only thing that jumped at me is that you need a parameter for the preprocessing strategy in load_confounds, and that you actually need to load the confounds before passing them to fit.

Another idea would be to not specify confound files at all, and use the fmri files to feed into load_confounds (the function then automatically looks for the associated fmriprep tsv file, which is named following a standard convention).

@pbellec
Copy link
Contributor

pbellec commented Dec 12, 2020

@dllussier any update?

@pbellec pbellec deleted the branch master April 11, 2022 03:16
@pbellec pbellec closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create a bash interface for dypac
2 participants
@dllussier @pbellec