Add function to clear transient storage array #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
approved these changes
Feb 6, 2025
|
Not sure how to do this with a linter, but you can add a nitpicker rule that would flag non public test function |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to clear the transient storage array. For gas efficiency, the actual transient storage is not cleared, however it's inaccessible after clearing. This function allows the transient storage array to be used as some kind of reentrancy guard (see #2).
Note that I also sneaked in a bug fix: a test was marked as
privateand notexternal, meaning that it wasn't actually being run. As a future improvement process, we should check with a linter that functions of the formtest_*are eitherpublicorexternal.How to test
New fuzz tests.