Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[myank] Pickups do not work #83

Closed
WolfgangDrescher opened this issue Nov 10, 2023 · 0 comments · Fixed by #84
Closed

[myank] Pickups do not work #83

WolfgangDrescher opened this issue Nov 10, 2023 · 0 comments · Fixed by #84

Comments

@WolfgangDrescher
Copy link
Contributor

WolfgangDrescher commented Nov 10, 2023

When I try to use e.g. cat test.krn | myank -l 2-10 on a file with a pickup before the first measure the command will fail and actually output the whole kern data and does not yank anything.

test.krn

**kern
4e
=1
4a
4g
4f
4e
=2
2d
4e
4b
=3
4cc
4cc
4b
4b
=4
1a;
==
*-

Expected output with myank -l 2-10

**kern
4e
=1
4a
4g
4f
4e
=2
2d
4e
*-

I tried to debug this, but I don't yet understand fully the logic of MeasureInfo and where it does get hydrated. It looks like in Tool_myank::processFile the expandMeasureOutList function does not assign anything to m_measureOutList. Would it make sense to add an additional MeasureInfo element that contains all notes before the first bar number (e.g. as NUMBER = 0 or NUMBER = -1) at the beginning of the vector?

@WolfgangDrescher WolfgangDrescher changed the title [myank] Upbeats do not work [myank] Pickups do not work Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant