From d2d44a5c6f9f882402d6cb63d4e5c4895cf06050 Mon Sep 17 00:00:00 2001 From: Andreas Motl Date: Sun, 30 Jul 2023 16:50:08 +0200 Subject: [PATCH] Chore: Satisfy linter admonition flake8 E721 The admonition was: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`. Apparently, it has been added to flake8 6.1.0, released on July 29, 2023 --- src/crate/testing/layer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/crate/testing/layer.py b/src/crate/testing/layer.py index 5fd6d8fd..ef8bfe2b 100644 --- a/src/crate/testing/layer.py +++ b/src/crate/testing/layer.py @@ -248,7 +248,7 @@ def __init__(self, transport_port or '4300-4399', settings) # ES 5 cannot parse 'True'/'False' as booleans so convert to lowercase - start_cmd = (crate_exec, ) + tuple(["-C%s=%s" % ((key, str(value).lower()) if type(value) == bool else (key, value)) + start_cmd = (crate_exec, ) + tuple(["-C%s=%s" % ((key, str(value).lower()) if isinstance(value, bool) else (key, value)) for key, value in settings.items()]) self._wd = wd = os.path.join(CrateLayer.tmpdir, 'crate_layer', name)