-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Yaml Parsing & CRD Selection #145
Comments
Follow up: Could actually probably still get the benefit of multi-doc and selection without |
As an update, I have observed panics on invalid YAMLs in |
Hmm. I'll add some panic handling to that method |
@RichiCoder1 it isn't too big of a problem because the pod just gets restarted. Feel free to leave as is if you don't want to invest the time because we should have improved parsing soon :) |
Random idea I had while thinking about some issues was to subsititute some of the current regex'd logic with some more robust code based on
yaml
andyqlib
.This code supports both multi docs and uses yq for selecting CRD Nodes.
Psuedocode:
Downside is YQ is not a light dependency
The text was updated successfully, but these errors were encountered: