Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ExternalSecretStores feature fail to start, fixes #175 #176

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

tomassatka
Copy link
Contributor

@tomassatka tomassatka commented Jan 24, 2025

Description of your changes

Fixes ExternalSecretStores feature prevention to crash the application

Fixes #175

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Running compiled binary locally with flag enabled

Detail for fix
Registering missing scheme:

func init() {
	// Register the types with the Scheme so the components can map objects to GroupVersionKinds and back
	AddToSchemes = append(AddToSchemes,
		gitlabv1beta1.SchemeBuilder.AddToScheme,
		groupsv1alpha1.SchemeBuilder.AddToScheme,
		projectsv1alpha1.SchemeBuilder.AddToScheme,
		gitlabv1alpha1.SchemeBuilder.AddToScheme, // HERE
	)
}

@dariozachow
Copy link
Collaborator

please rebase on master

@tomassatka
Copy link
Contributor Author

tomassatka commented Feb 10, 2025

@dariozachow can you please merge now?

@dariozachow dariozachow merged commit 1774cba into crossplane-contrib:master Feb 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExternalSecretStores feature fail to start
2 participants