[Bug] Updating multiple channel rewards by tag fails with Unhandled promise rejection

[k3lwin]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Hi!

I've set up a couple commands that should enable and disable multiple channel rewards. While an effect to update each channel reward individually works fine, trying to address multiple rewards via tag fails with following error:

[2025-01-13 11:37:06.0216] - debug: [v5.63.2] Running firebot:update-channel-reward(4bb615e0-c637-11ef-ba2d-b7726e0d709b) effect...
[2025-01-13 11:37:06.0217] - error: [v5.63.2] Unhandled promise rejection 
{
  message: "Cannot read properties of undefined (reading 'includes')",
  stack: "TypeError: Cannot read properties of undefined (reading 'includes')\n" +
    '    at C:\\Users\\k3lwi\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\effects\\builtin\\update-channel-reward.js:271:47\n' +
    '    at Array.filter (<anonymous>)\n' +
    '    at Object.onTriggerEvent (C:\\Users\\k3lwi\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\effects\\builtin\\update-channel-reward.js:271:14)\n' +
    '    at C:\\Users\\k3lwi\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\common\\effect-runner.js:89:40\n' +
    '    at new Promise (<anonymous>)\n' +
    '    at triggerEffect (C:\\Users\\k3lwi\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\common\\effect-runner.js:68:12)\n' +
    '    at C:\\Users\\k3lwi\\AppData\\Local\\firebot\\app-5.63.2\\resources\\app.asar\\build\\backend\\common\\effect-runner.js:147:40\n' +
    '    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)'
}
[2025-01-13 11:37:06.0235] - debug: [v5.63.2] Checking for command in message...

Effect JSON as follows:

{"id":"4bb615e0-c637-11ef-ba2d-b7726e0d709b","type":"firebot:update-channel-reward","active":true,"rewardSettings":{"name":{"update":false,"newValue":""},"description":{"update":false,"newValue":""},"cost":{"update":false,"newValue":"1"},"enabled":{"update":true,"newValue":true},"paused":{"update":false,"newValue":"toggle"}},"useTag":true,"sortTagId":"c53f643b-e805-492f-b3c0-0d18017768c0","percentWeight":null}

Similar effect has no issue updating individual rewards.

Expected Behavior

Multiple channel rewards with tag ID c53f643b-e805-492f-b3c0-0d18017768c0 should be updated when effect addresses them via tag.

Steps To Reproduce

1. Create multiple channel rewards
2. Assign a tag to multiple rewards
3. Create effect "Update channel reward", tick "Use sort tags", select tag
4. Trigger an effect

Version

5.63.2

What operating system are you using Firebot on?

Windows 11

Relevant log output

No response

Contact Details (Optional)

No response

Edit: fixed markdown typos

[dennisrijsdijk]

Duplicate of #2861, fixed in v5 and Nightly