Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubops tests #3393

Merged
merged 11 commits into from
Jan 7, 2025
Merged

Hubops tests #3393

merged 11 commits into from
Jan 7, 2025

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 3, 2025

No description provided.

@mmetc mmetc added this to the 1.6.5 milestone Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.08%. Comparing base (9dfa74b) to head (f759d25).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cwhub/state.go 93.10% 2 Missing ⚠️
pkg/cwhub/sync.go 60.00% 1 Missing and 1 partial ⚠️
pkg/cwhub/hub.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3393      +/-   ##
==========================================
+ Coverage   59.02%   59.08%   +0.06%     
==========================================
  Files         358      359       +1     
  Lines       38676    38646      -30     
==========================================
+ Hits        22827    22833       +6     
+ Misses      13922    13892      -30     
+ Partials     1927     1921       -6     
Flag Coverage Δ
bats 42.12% <84.78%> (-0.10%) ⬇️
unit-linux 32.79% <73.91%> (+0.09%) ⬆️
unit-windows 28.18% <73.91%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the hubops-tests branch 2 times, most recently from 1a9cfcc to cb6feb8 Compare January 6, 2025 08:44
@mmetc mmetc marked this pull request as ready for review January 6, 2025 09:02
@mmetc mmetc requested a review from buixor January 6, 2025 09:03
@mmetc mmetc requested a review from sabban January 7, 2025 14:50
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 866b0ad into master Jan 7, 2025
17 checks passed
@mmetc mmetc deleted the hubops-tests branch January 7, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants