Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Long-running file operations can fail internally #782

Open
andrewazores opened this issue Jan 23, 2025 · 0 comments
Open

[Bug] Long-running file operations can fail internally #782

andrewazores opened this issue Jan 23, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

andrewazores commented Jan 23, 2025

Current Behavior

Related to #698

try (var stream = getActiveInputStream(recording);

return remoteRecordingStreamFactory.open(recording);

return connectionManager.executeConnectedTask(

return executeConnectedTaskUni(target, task).await().atMost(failedTimeout);

Operations that are expected to potentially take a long time, in particular ones dealing with active recording JFR files (archiving, uploading to jfr-datasource, report generation), still use the default 10 second connection timeout. If the operation has not completed within this timeframe then the connection is internally failed, the job aborted, and the failure reported to the client(s). However, for large recordings, we should expect that these operations can take a much longer time to complete than 10 seconds.

The 10 second connection timeout is still useful for operations that are not expected to take very long, like listing event types or querying for a list of active recordings in the target, so I think those should still use the default timeout length (but maybe we should increase the timeout from 10 seconds to ex. 30 seconds). The particular operations like archiving the recording, or uploading it to jfr-datasource, should use a separate and significantly longer timeout period now that we have the async job notifications API.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- OS:
- Environment:
- Version:

Anything else?

No response

@andrewazores andrewazores added the bug Something isn't working label Jan 23, 2025
@andrewazores andrewazores moved this to Ready in 4.0.0 release Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

2 participants