You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Operations that are expected to potentially take a long time, in particular ones dealing with active recording JFR files (archiving, uploading to jfr-datasource, report generation), still use the default 10 second connection timeout. If the operation has not completed within this timeframe then the connection is internally failed, the job aborted, and the failure reported to the client(s). However, for large recordings, we should expect that these operations can take a much longer time to complete than 10 seconds.
The 10 second connection timeout is still useful for operations that are not expected to take very long, like listing event types or querying for a list of active recordings in the target, so I think those should still use the default timeout length (but maybe we should increase the timeout from 10 seconds to ex. 30 seconds). The particular operations like archiving the recording, or uploading it to jfr-datasource, should use a separate and significantly longer timeout period now that we have the async job notifications API.
Expected Behavior
No response
Steps To Reproduce
No response
Environment
- OS:
- Environment:
- Version:
Anything else?
No response
The text was updated successfully, but these errors were encountered:
Current Behavior
Related to #698
cryostat/src/main/java/io/cryostat/recordings/RecordingHelper.java
Line 824 in fceff9d
cryostat/src/main/java/io/cryostat/recordings/RecordingHelper.java
Line 977 in fceff9d
cryostat/src/main/java/io/cryostat/recordings/RemoteRecordingInputStreamFactory.java
Line 37 in fceff9d
cryostat/src/main/java/io/cryostat/targets/TargetConnectionManager.java
Line 207 in fceff9d
Operations that are expected to potentially take a long time, in particular ones dealing with active recording JFR files (archiving, uploading to jfr-datasource, report generation), still use the default 10 second connection timeout. If the operation has not completed within this timeframe then the connection is internally failed, the job aborted, and the failure reported to the client(s). However, for large recordings, we should expect that these operations can take a much longer time to complete than 10 seconds.
The 10 second connection timeout is still useful for operations that are not expected to take very long, like listing event types or querying for a list of active recordings in the target, so I think those should still use the default timeout length (but maybe we should increase the timeout from 10 seconds to ex. 30 seconds). The particular operations like archiving the recording, or uploading it to jfr-datasource, should use a separate and significantly longer timeout period now that we have the async job notifications API.
Expected Behavior
No response
Steps To Reproduce
No response
Environment
Anything else?
No response
The text was updated successfully, but these errors were encountered: