Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry logic for foundryup #69

Open
elopez opened this issue Jan 31, 2024 · 0 comments · May be fixed by #71
Open

Add retry logic for foundryup #69

elopez opened this issue Jan 31, 2024 · 0 comments · May be fixed by #71

Comments

@elopez
Copy link
Member

elopez commented Jan 31, 2024 •
edited
Loading 

          thanks @mds1 that's a good point 
          
          Looking at the error message, it might also be https://github.com/foundry-rs/foundry/issues/3942 (which would explain why the tests are passing in @pcaversaccio CI).

          @elopez : maybe we can update the commit used for foundryup, and if installing foundry fails, we do a `sleep` for 1-2 second, and try again?

Originally posted by @montyly in #66 (comment)
elopez added a commit that referenced this issue Feb 13, 2024
@elopez
Rework Foundry installation
a5b2687 
The action will now attempt to run `foundryup` multiple times in an
attempt to make the installation more reliable. A new action parameter,
`foundry-version`, is now available as well, so users can lock in
a known-working Foundry version if needed.

Closes #69
@elopez elopez linked a pull request Feb 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework Foundry installation crytic/slither-action
1 participant
@elopez