Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove protocol.name #104

Open
michielbdejong opened this issue Sep 3, 2024 · 2 comments
Open

Remove protocol.name #104

michielbdejong opened this issue Sep 3, 2024 · 2 comments
Labels
v2 RFE or breaking change for v2.0

Comments

@michielbdejong
Copy link
Contributor

It occured to me that except for the singleProtocolLegacy in https://cs3org.github.io/OCM-API/docs.html?branch=v1.1.0&repo=OCM-API&user=cs3org#/paths/~1shares/post we don't really need the "name": "webdav" or "name": "multi", right? Can we remove it in singleProtocolNew and multipleProtocols?
@michielbdejong michielbdejong mentioned this issue Sep 6, 2024
Closed
@glpatcern
Copy link
Member

I definitely remember a lot of resistance on that, because removing name essentially is a breaking change w.r.t. OCM 1.0.

@glpatcern
Copy link
Member

Following my comment in #127, I think we can deprecate protocol.name in the prospect 1.2, and remove it with OCM 2.0.

@glpatcern glpatcern mentioned this issue Sep 12, 2024
Merged
@glpatcern glpatcern added the v2 RFE or breaking change for v2.0 label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2 RFE or breaking change for v2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michielbdejong @glpatcern