Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using UCTS timestamp? #155

Open
maxnoe opened this issue Sep 21, 2022 · 5 comments
Open

Switch to using UCTS timestamp? #155

maxnoe opened this issue Sep 21, 2022 · 5 comments

Comments

@maxnoe
Copy link
Member

maxnoe commented Sep 21, 2022

From a discussion with @FrancaCassol, since UCTS is in principle the more precise timestamp and by design the component meant to provide the timestamps, we should probably switch to just using the UCTS provided timestamp instead of the dragon counter based timestamp, at least for data after the TIB firmware upgrade that fixed most of the issues related to unreliable UCTS info in the files.

Opinions, @moralejo, @rlopezcoto?

@rlopezcoto
Copy link
Contributor

Sounds good, but if we have to reprocess some old data, it would be great to get a check that selects the dragon counter based timestamp for data before TIB firmware upgrade

@moralejo
Copy link
Contributor

Ok with me too. Would a runnumber-based default behaviour be fine?
I understand we will still calculate the dragon timestamp, and keep checking for possible jumps in the ucts info, correct?.

@maxnoe
Copy link
Member Author

maxnoe commented Sep 22, 2022

I understand we will still calculate the dragon timestamp, and keep checking for possible jumps in the ucts info, correct?.

For now, yes. The question is what to fill into the ctapipe event.trigger.time field after that has happened

@maxnoe
Copy link
Member Author

maxnoe commented Sep 22, 2022

Would a runnumber-based default behaviour be fine?

Yes, or date. For the use_flatfield_heuristic, which has the same underlying cause I think (the TIB firmware upgrade) we check if the run was after 2022-01-01.

Let's do the same here?

@moralejo
Copy link
Contributor

moralejo commented Oct 4, 2022

We also have recent data in which the UCTS info was not available, but ok, we will just have to override the default in those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants