New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename `theta_cuts` arguments to `spatial_selection_table` #297

Open

LukasBeiske opened this issue Jan 21, 2025 · 0 comments

Contributor

LukasBeiske commented Jan 21, 2025 •

edited

Loading

Also, this is more in line with the fact that we don't use the term "point-like IRFs" anymore, and instead use "SpatialSelection=None | RAD_MAX"

Originally posted by @kosack in cta-observatory/ctapipe#2473 (comment)

LukasBeiske changed the title general comment for here and other places: since we have options point_like and source_is_pointlike, this is quite confusing. Maybe rename point_like to direction_cut_applied or spatial_selection_applied. That will make it much easier to follow. Also, this is more in line with the fact that we don't use the term "_point-like IRFs_" anymore, and instead use "_SpatialSelection=None | RAD_MAX_" Rename theta_cuts arguments to spatial_selection_table

LukasBeiske mentioned this issue

Irf maker and cut optimiser cta-observatory/ctapipe#2473

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment