Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serving of edition-webpages images #184

Open
njr2128 opened this issue Sep 15, 2021 · 1 comment
Open

serving of edition-webpages images #184

njr2128 opened this issue Sep 15, 2021 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@njr2128
Copy link
Member

njr2128 commented Sep 15, 2021

Images from edition-webpages

  • Seem to be served directly from github rather than from an S3 build bc we are using raw links to github
    • e.g., https://raw.githubusercontent.com/cu-mkp/edition-webpages/master/images/howtouse-listentries.png
  • One option: once the application is built, need to rewrite these images to relative links once the application is built
  • Better option: If ok with possibly not being viewable within github’s preview interface, then we can write the relative links in the source file to begin with in edition-webpages
    • e.g., ![how-to-use-dualpane](../images/howtouse-dualpane.png) or ![verdigris-header](../images/verdigris-header.png?raw=true)
    • we would need a site with constant update (i.e., staging or dev)
@njr2128 njr2128 added the bug Something isn't working label Sep 15, 2021
@njr2128 njr2128 added question Further information is requested and removed bug Something isn't working labels Mar 16, 2022
@njr2128
Copy link
Member Author

njr2128 commented Mar 16, 2022

Next steps: ask Nick how to integrate this into the Edition generating code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: To do
Development

No branches or pull requests

3 participants