Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow styling of notes/EditorComment #154

Open
pdaengeli opened this issue Dec 10, 2024 · 0 comments
Open

Allow styling of notes/EditorComment #154

pdaengeli opened this issue Dec 10, 2024 · 0 comments

Comments

@pdaengeli
Copy link

First of all, thanks for this nice tool. We are evaluating it and might use it for some smaller edition projects.

As the red asterisk risks to be too prominent for some editions it would be great to have a way to influence the styling of the reference marker.

Currently, styles are assigned inline in EditorComment.js#L41-L48:

  const style = { display: 'inline' }
  const asteriskStyle = { fontStyle: 'bold', fontSize: '18pt', color: 'red' }
  return (
    <div style={style}>
      <span onClick={e => onOpen(e)} style={asteriskStyle}>*</span>
      {renderPopper()}
    </div>
  )

Would you consider adding a class on the div or span, e.g., refMark?

Another idea is to re-use tei-note, but I can't judge potential side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant