Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add categories attribute to part and continued divs #2074

Open
tcatapano opened this issue Apr 26, 2023 · 8 comments
Open

add categories attribute to part and continued divs #2074

tcatapano opened this issue Apr 26, 2023 · 8 comments
Assignees
Labels
bug cleanup Cleaning up old files and clutter consistency markup

Comments

@tcatapano
Copy link
Member

seem to missing them. See 128r1:

<div id="p128r_1" part="y" continued="yes">
<ab>When your <tl>mold</tl> starts to redden on the inside, <del>&amp;

@njr2128
Copy link
Member

njr2128 commented Nov 26, 2024

Confirm whether "part" divs have categories. If not, add them.

@njr2128 njr2128 moved this from To do to In progress in DCE final campaign Jan 20, 2025
@tcatapano
Copy link
Member Author

tcatapano commented Jan 20, 2025

The only divs in ms-xm/tc has part="y" and categories is "La Boutique" divs p162r1

<div id="p162r_1" categories="La boutique" part="y">
<ab>

<pn>Herodote</pn> au premier foeuillet de <el>Clio</el> dict que les
<pl>grecs</pl> furent<lb/>

but not continues?!

@tcatapano
Copy link
Member Author

These are the //div[@part][@continued]

continued="yes" id="p016r_1" part="y"
continued="yes" id="p017r_1" part="y"
continued="yes" id="p024v_1" part="y"
continued="yes" id="p053v_1" part="y"
continued="yes" id="p066r_6" part="y"
continued="yes" id="p069r_2" part="y"
continued="yes" id="p085v_4" part="y"
continued="yes" id="p094r_1" part="y"
continued="yes" id="p094r_1" part="y"
continued="yes" id="p106v_2" part="y"
continued="yes" id="p107r_1" part="y"
continued="yes" id="p123r_1" part="y"
continued="yes" id="p128r_1" part="y"
continued="yes" id="p146v_1" part="y"

@tcatapano
Copy link
Member Author

see 105r_4 for problematic markup of discontinuous divs:

<div id="p105r_4" categories="cultivation" continued="yes">
<div continues="yes" id="p105r_4" categories="cultivation">
<div id="p105r_4" part="y">

@tcatapano tcatapano moved this from In progress to Blocked in DCE final campaign Jan 20, 2025
@tcatapano
Copy link
Member Author

Important to understand role of attributes: see attribute descriptions starting with continued: https://github.com/cu-mkp/m-k-manuscript-data/blob/master/schema/ms-transcription.md#continues

cont (continues): An attribute indicating the parent block continues from another page

a.continues = attribute continues { "yes" }

continued

cont (continued): An attribute indicating that the parent block is continued on another page

a.continued = attribute continued { "yes" }

categories

Categories: A semi-colon delimited list of controlled terms assigned by the project to a text division

a.categories = attribute categories { xsd:token }

part

Part: Indicates that a div is a part of the same text division which shares the same id on the same folio page. Values are "y" and "n".

a.part = attribute part { "y" | "n" }

continues/continued span pages and imply part; part implies continues on same page so markup of 105r_4 is correct.

but still need to add categories for continued/continues divs

@tcatapano tcatapano changed the title add categories attribute to part divs add categories attribute to part and continued divs Jan 20, 2025
@tcatapano
Copy link
Member Author

//div[@part][not(@continues)][not(@continued)]:

categories="La boutique" id="p162r_1" part="y"
categories="La boutique" id="p162r_1" part="y"
categories="La boutique" id="p162r_1" part="y"
categories="La boutique" id="p162r_1" part="y"
id="p001r_3" part="y"
id="p003r_2" part="y"
id="p006v_1" part="y"
id="p014r_1" part="y"
id="p016r_1" part="y"
id="p023r_1" part="y"
id="p024v_1" part="y"
id="p024v_1" part="y"
id="p028v_1" part="y"
id="p029v_6" part="y"
id="p033r_1" part="y"
id="p045r_1" part="y"
id="p046v_4" part="y"
id="p062v_2" part="y"
id="p065r_4" part="y"
id="p065v_6" part="y"
id="p065v_7" part="y"
id="p066r_6" part="y"
id="p066r_6" part="y"
id="p094r_1" part="y"
id="p105r_4" part="y"
id="p105v_4" part="y"
id="p106v_3" part="y"
id="p108r_2" part="y"
id="p113r_1" part="y"
id="p114r_1" part="y"
id="p114r_1" part="y"
id="p115r_1" part="y"
id="p120r_2" part="y"
id="p125r_1" part="y"
id="p125r_1" part="y"
id="p125r_1" part="y"
id="p126v_3" part="y"
id="p127v_1" part="y"
id="p130v_1" part="y"
id="p135r_1" part="y"
id="p137r_1" part="y"
id="p140v_3" part="y"
id="p141r_1" part="y"
id="p144r_1" part="y"
id="p145v_2" part="y"
id="p146v_1" part="y"
id="p150v_1" part="y"
id="p157r_5" part="y"
id="p158r_1" part="y"
id="p160r_1" part="y"
id="p161r_1" part="y"
id="p170r_6" part="y"

@tcatapano
Copy link
Member Author

//div[@part][@continues | @continued]

continued="yes" id="p016r_1" part="y"
continued="yes" id="p017r_1" part="y"
continued="yes" id="p024v_1" part="y"
continued="yes" id="p053v_1" part="y"
continued="yes" id="p066r_6" part="y"
continued="yes" id="p069r_2" part="y"
continued="yes" id="p085v_4" part="y"
continued="yes" id="p094r_1" part="y"
continued="yes" id="p094r_1" part="y"
continued="yes" id="p106v_2" part="y"
continued="yes" id="p107r_1" part="y"
continued="yes" id="p123r_1" part="y"
continued="yes" id="p128r_1" part="y"
continued="yes" id="p146v_1" part="y"

@tcatapano
Copy link
Member Author

except for data analysis purposes, not sure how consequential this is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cleanup Cleaning up old files and clutter consistency markup
Projects
Status: Blocked
Development

No branches or pull requests

2 participants