Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

learning rate seems not properly be set when training with "self.args.resume == True" #70

Open
DSonDH opened this issue May 12, 2023 · 0 comments

Comments

@DSonDH
Copy link

DSonDH commented May 12, 2023

for example of SCINet/experiments/exp_ETTh.py,

I think

        if self.args.resume:
            self.model, lr, epoch_start = load_model(self.model, path, model_name=self.args.data, horizon=self.args.horizon)
        else:
            epoch_start = 0

should be above line 227,

model_optim = self._select_optimizer()

and

self.args.lr = lr 

should be added above line 227.

The load_model() function brings last learning rate from loaded model successfully.
But optimizer cannot set that learning rate for optimization because optimizer is called first.
It seems optimizer only takes self.args.lr and it is not the value from the loaded model.

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant