Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected "/socketpeer/" default path #30

Open
donmccurdy opened this issue Jan 16, 2016 · 2 comments
Open

Unexpected "/socketpeer/" default path #30

donmccurdy opened this issue Jan 16, 2016 · 2 comments

Comments

@donmccurdy
Copy link
Contributor

Took me a bit to figure out why my websockets were all pending but not rejecting. The client (I'm using it independently and not as part of the built-in demo) has the default path http://localhost, but the server expects a default path ending in /socketpeer/, even when I pass in the httpServer or host options.

Would you be open to one of these?

  1. Change default path to /socketpeer/ in client.
  2. Make default path for server / if it's not running in demo mode.
  3. Provide option to override server path.

Thanks!

@potch
Copy link
Collaborator

potch commented Mar 20, 2017

@donmccurdy I like these suggestions- do you have a preference of which of these best matches your expectations?

@donmccurdy
Copy link
Contributor Author

@potch thanks, an option to override the path in the server here would probably be my preference.

Reconsidering, I don't think (1) alone is a good choice because the user will often need to provide the url parameter to specify their host, losing any default path. It would be OK if the client had separate host and path parameters, maybe, so that the host could be overridden and the default path would be more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants