Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lone custom outputs ignored #6508

Open
hjoliver opened this issue Dec 3, 2024 · 2 comments · May be fixed by #6583
Open

lone custom outputs ignored #6508

hjoliver opened this issue Dec 3, 2024 · 2 comments · May be fixed by #6583
Assignees
Labels
bug Something is wrong :( small
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Dec 3, 2024

This validates OK, and :x is ignored in the completion expression (same for a:x?):

[scheduling]
   [[graph]]
        R1 = "a:x"
[runtime]
   [[a]]  # no outputs defined

But triggering another task off the output results in a warning:

[scheduling]
   [[graph]]
        R1 = "a:x => b"
[runtime]
   [[a]]  # no outputs defined
   [[b]]
WorkflowConfigError: Undefined custom output: a:x
@hjoliver hjoliver added the bug Something is wrong :( label Dec 3, 2024
@hjoliver hjoliver added this to the 8.x milestone Dec 3, 2024
@MetRonnie MetRonnie modified the milestones: 8.x, 8.3.7 Dec 4, 2024
@MetRonnie MetRonnie added the small label Dec 4, 2024
@hjoliver hjoliver modified the milestones: 8.3.7, 8.4.1 Jan 8, 2025
@wxtim
Copy link
Member

wxtim commented Jan 22, 2025

@hjoliver Do you want to make validation fail?

[scheduling]
   [[graph]]
        R1 = "a:x"
[runtime]
   [[a]]  # no outputs defined

fail validation?

@wxtim wxtim self-assigned this Jan 29, 2025
@wxtim wxtim linked a pull request Jan 30, 2025 that will close this issue
8 tasks
@wxtim wxtim linked a pull request Jan 30, 2025 that will close this issue
8 tasks
@wxtim
Copy link
Member

wxtim commented Feb 3, 2025

I think that I've convinced myself that this graph should raise an error - but not that error. And, that foo:x or bar => foo:x should raise an error whether or not outputs are defined. This is becuase a qualifier at the right hand end of a graph sequence will never have any effect, and is therefore always a user error. If the user expects it to have any effect they are wrong, and Cylc should fail harder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants