Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

special case "row.names" attribute #356

Closed
moodymudskipper opened this issue Apr 9, 2024 · 0 comments · Fixed by #358
Closed

special case "row.names" attribute #356

moodymudskipper opened this issue Apr 9, 2024 · 0 comments · Fixed by #358

Comments

@moodymudskipper
Copy link
Collaborator

There's a weird internal thing going on to automate row names, and while identical doesn't see it, it has (rare) consequences.

https://twitter.com/antoine_fabri/status/1777636463980499038

tidyverse/tibble#1571

I don't know of a way to assess which method was used without trying 1 and comparing to the original object after serialisation. I think we don't want to do that though due to the overhead. I think the auto names should be the default in non artificial cases, it's what dput does too. So let's do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant