Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚🐛 Some demos in the docs are broken due to 404 error fetching cytoscape.min.js #3259

Closed
7 tasks
s-weigand opened this issue Jul 14, 2024 · 1 comment
Closed
7 tasks
Labels
bug A bug in the code of Cytoscape.js
Milestone

Comments

@s-weigand
Copy link
Contributor

Currently, some demos (e.g edge-types) are broken due to the missing cytoscape.min.js (https://js.cytoscape.org/js/cytoscape.min.js).
image

The reason for this is that the file got copied into a build subfolder of the js folder on the gh-pages branch
image

The dependabot update in #3247 bumped cpy-cli from 3.1.1 to 5.0.0 where 4.0.0 introduced the breaking change:

Remove the --parents flag. The copy is now recursive by default. To get flat output, use the --flat flag.

Note that some demos (e.g. edgehandles) still work because they use https://unpkg.com/[email protected]/dist/cytoscape.min.js instead of https://js.cytoscape.org/js/cytoscape.min.js.

Current (buggy) behaviour

Some demos are broken because https://js.cytoscape.org/js/cytoscape.min.js gives a 404 HTTP error.

Desired behaviour

All demos work.

Minimum steps to reproduce

Go to the edge-types demo in current docs and see that it is broken (open browser dev tools to see why).

Alternatively, locally build the doc for the current version of the default branch locally

npm ci && npm run build:min && npm run docs

Serve the documentation folder locally and visit the edge-types demo

For reviewers

Reviewers should ensure that the following tasks are carried out for incorporated issues:

  • Ensure that the reporter has included a reproducible demo. They can easily fork this JSBin demo: http://jsbin.com/fiqugiq
  • The issue has been associated with a corresponding milestone.
  • The commits have been incorporated into the corresponding branches. Bug-fix patches go on
    • master,
    • unstable, and
    • the previous feature release branch (e.g. 1.1.x if the current release is 1.2).
  • The issue has been labelled as a bug, if necessary.
@s-weigand
Copy link
Contributor Author

Duplicate of #3257 but with explanations 😅

@maxkfranz maxkfranz added this to the 3.30.1 milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in the code of Cytoscape.js
Projects
None yet
Development

No branches or pull requests

2 participants