Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering an existing HydroShare resource that I can't edit shouldn't take me to the edit page #152

Open
horsburgh opened this issue Jan 28, 2025 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@horsburgh
Copy link

Description of the bug

If a user registers an existing HydroShare resource using its URL, the DSP retrieves the metadata for that resource and takes the user directly to the edit page for that resource. If the user is not authorized to edit that resource, the user cannot save or finish.

Steps to reproduce the bug:

  1. Get the URL for any HydroShare resource that is public but that you do not have edit permissions on. Try this one: https://www.hydroshare.org/resource/7440c7feae1f428d91c1e510d23d3e54/
  2. Try to register that resource with the DSP.
  3. You will be taken to the edit page in the DSP for that resource.
  4. You can click on the Save or Finish buttons but you end up in an endless authorization loop with HydroShare because you do not have permission to edit the resource.

Expected behavior

  • When a user tries to register the resource, they should see the preview on the register page, but they should not be automatically taken to the Edit page.
  • The button they see should not say "Continue & Edit...", it should just say "Continue" or "Register Dataset"
  • They should be taken to the "My Submissions" page where they see the new resource registered.
  • The DSP must detect that they do not have edit permissions on the resource and should treat it like a published resource that they cannot edit.
  • The user should see the "View in Repository", "Update Record", and "Delete" buttons, but they should not see the "Edit" button because they do not have permission to edit.

Additional information

NA

@horsburgh horsburgh added the bug Something isn't working label Jan 28, 2025
@horsburgh horsburgh added this to the v1.6.0 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants