From ccc907a71fc8ff1fafa837c8cb9f01a9aa2cb5ed Mon Sep 17 00:00:00 2001 From: Colton Padden Date: Sat, 1 Feb 2025 18:52:07 -0500 Subject: [PATCH 1/3] [docs] add some margin and padding to api docs --- docs/docs-beta/src/styles/custom.scss | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/docs-beta/src/styles/custom.scss b/docs/docs-beta/src/styles/custom.scss index 09fec181ff081..9bb2179d35b63 100644 --- a/docs/docs-beta/src/styles/custom.scss +++ b/docs/docs-beta/src/styles/custom.scss @@ -493,7 +493,8 @@ table { /* API Docs */ dl { - padding: 4px 0px 0px 4px; + padding: 6px; + margin-top: 6px; border: 1px solid var(--theme-color-keyline); font-weight: 200; background-color: var(--theme-color-background-blue); @@ -518,7 +519,7 @@ dd { } dd p { - margin: 0; + margin-bottom: 8px; } dd code { From d1fcbcc3195aa5dc4ac8cd5932d799319d0deabe Mon Sep 17 00:00:00 2001 From: Colton Padden Date: Sat, 1 Feb 2025 19:01:24 -0500 Subject: [PATCH 2/3] Remove padding from last p element --- docs/docs-beta/src/styles/custom.scss | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/docs-beta/src/styles/custom.scss b/docs/docs-beta/src/styles/custom.scss index 9bb2179d35b63..920568de8d47b 100644 --- a/docs/docs-beta/src/styles/custom.scss +++ b/docs/docs-beta/src/styles/custom.scss @@ -519,7 +519,10 @@ dd { } dd p { - margin-bottom: 8px; + margin-bottom: 6px; + &:last-child { + margin-bottom: 0px; + } } dd code { From a3f13db75deb8e6226333d9394413cd4e110b1e8 Mon Sep 17 00:00:00 2001 From: Colton Padden Date: Mon, 3 Feb 2025 12:56:59 -0500 Subject: [PATCH 3/3] ammend --- .../_ext/dagster-sphinx/dagster_sphinx/docstring_flags.py | 2 +- .../dagster/dagster/_core/definitions/step_launcher.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/sphinx/_ext/dagster-sphinx/dagster_sphinx/docstring_flags.py b/docs/sphinx/_ext/dagster-sphinx/dagster_sphinx/docstring_flags.py index fe9a2a6acfce0..4ee28f24d8876 100644 --- a/docs/sphinx/_ext/dagster-sphinx/dagster_sphinx/docstring_flags.py +++ b/docs/sphinx/_ext/dagster-sphinx/dagster_sphinx/docstring_flags.py @@ -38,7 +38,7 @@ def inject_object_flag( elif isinstance(info, SupersededInfo): additional_text = f" {info.additional_warn_text}." if info.additional_warn_text else "" flag_type = "superseded" - message = f"This API has been superseded and its usage is discouraged.\n{additional_text}" + message = f"This API has been superseded.\n{additional_text}" elif isinstance(info, PreviewInfo): additional_text = f" {info.additional_warn_text}." if info.additional_warn_text else "" flag_type = "preview" diff --git a/python_modules/dagster/dagster/_core/definitions/step_launcher.py b/python_modules/dagster/dagster/_core/definitions/step_launcher.py index 9e6fdb414b6e5..228efce0f1c9b 100644 --- a/python_modules/dagster/dagster/_core/definitions/step_launcher.py +++ b/python_modules/dagster/dagster/_core/definitions/step_launcher.py @@ -60,7 +60,7 @@ def __new__( _step_launcher_supersession = superseded( subject="StepLauncher", - additional_warn_text="This API has been superseded, but there is no plan to remove this functionality. For new projects, we recommend using Dagster Pipes. For more information, see https://docs.dagster.io/guides/build/external-pipelines/", + additional_warn_text="While there is no plan to remove this functionality, for new projects, we recommend using Dagster Pipes. For more information, see https://docs.dagster.io/guides/build/external-pipelines/", )