Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The answer to question #6 of chapter 13 seems wrong. #14

Closed
danli349 opened this issue Dec 26, 2024 · 2 comments · Fixed by #15
Closed

The answer to question #6 of chapter 13 seems wrong. #14

danli349 opened this issue Dec 26, 2024 · 2 comments · Fixed by #15
Assignees

Comments

@danli349
Copy link

danli349 commented Dec 26, 2024

Hello:

I think the answer to question #6 (c,d) of chapter 13 (https://danhalligan.github.io/ISLRv2-solutions/multiple-testing.html) is wrong.
The FDP is defined with V/(V+S), which is (false positive)/(false positive+true positive),
For Bonferroni procedure the false discovery rate will be 0/7, 0/7, 0/3.
For Holm procedure the false discovery rate will be 0/7, 0/8, 0/8.
image

image

@danhalligan
Copy link
Owner

Agreed -- this looks like an error thanks. Do you want to make a pull request and I'll merge in? If not, I can make the edits.

@danli349
Copy link
Author

@danhalligan you can make the edits, thanks

@danhalligan danhalligan self-assigned this Dec 31, 2024
@danhalligan danhalligan linked a pull request Dec 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants