Breaking errors when using some custom templates

[nevaran]

Vaultwarden Support String

After adding custom templates/email files with environment, the email and organization invitations cease to function. Tested most of the /email .hbs files and for now I found just the send_org_invite.hbs and send_org_invite.html.hbs to be breaking functionality in the /email folder. It would seem that it just simply cannot find a org_id variable from looking at the logs.
Adding the /admin templates breaks the admin panel as well, though I have not tested that one any further than "buttons does not even react and the web GUI is wrong colors".

Vaultwarden Build Version

v1.32.5

Deployment method

Official Container Image

Custom deployment method

Portainer compose with pre-made directories

Reverse Proxy

NPM v2.12.1

Host/Server Operating System

Linux

Operating System Version

Ubuntu 24.04 LTS

Clients

Web Vault, Browser Extension, Desktop, Android

Client Version

latest

Steps To Reproduce

1. Add "TEMPLATES_FOLDER=/data/templates" environment variable
2. Add templates/email folder with the mentioned file downloaded from the github repo - does not matter if it is modified or not afterwards
3. Restart container
4. Attempt to send invites from admin panel

Expected Result

Send invites to join vault and/or organization

Actual Result

Cannot send invite; Handlebars error.

Container logs:

Logs

[2024-11-27 08:07:43.134][request][INFO] POST /admin/invite

[2024-11-27 08:07:43.136][error][ERROR] Handlebars.

[CAUSE] RenderError {

    template_name: Some(

        "email/send_org_invite.html",

    ),

    line_no: Some(

        12,

    ),

    column_no: Some(

        65,

    ),

    reason: MissingVariable(

        Some(

            "org_id",

        ),

    ),

    unimplemented: false,

}

[2024-11-27 08:07:43.136][response][INFO] (invite_user) POST /admin/invite => 500 Internal Server Error

[2024-11-27 08:07:44.470][request][INFO] GET /admin/users/overview

[2024-11-27 08:07:44.471][response][INFO] (users_overview) GET /admin/users/overview => 200 OK

Screenshots or Videos

Additional Context

Without the template file the invite is send and the link's org_id is just _ , attempting to modify the .hbs file with just that as well instead of variable fetching results in the same error.

[BlackDex]

There is no org_id anymore in that part of the code

https://github.com/dani-garcia/vaultwarden/blob/cdfdc6ff4f61a7495cd70609c0d9098ff10b55a4/src/mail.rs#L296...L301

It is also not in the template https://github.com/dani-garcia/vaultwarden/blob/1.32.5/src/static/templates/email/send_org_invite.html.hbs

The template files are all correct. And as mentioned in several of our recent releases the templates have changed and you need to update them accordingly.

Also, if you send an invite via the Vaultwarden Backend admin interface, then the org will be _ in the url.

Invites to an organization need to be done via the web-vault via the Admin Console and then members.

[nevaran]

Ok seems like I was missing the latest of those two files. Not sure why downloading the project zip still ended with the old template for those two files.

[BlackDex]

You only need to add files to the template folders which you want to modify or replace. Everything else will be using the built-in version, which should always be correct.

[nevaran]

Thats what I did. But for some reason the project zip i downloaded to get the templates had an older version of those org invite files.