From a5f2b1480b6ee714b659aaf1f1ac8b4b242b41a5 Mon Sep 17 00:00:00 2001 From: danicc097 Date: Sun, 19 Jan 2025 10:50:23 +0100 Subject: [PATCH] delete go loop copy vars --- bin/templates/crud-api-tests.go.tmpl.bash | 2 -- bin/templates/crud-repo-tests.go.tmpl.bash | 3 --- bin/templates/crud-service-tests.go.tmpl.bash | 1 - internal/codegen/codegen_test.go | 2 -- internal/repos/postgresql/repo_activity_test.go | 2 -- internal/repos/postgresql/repo_kanban_step_test.go | 2 -- internal/repos/postgresql/repo_project_test.go | 1 - internal/repos/postgresql/repo_team_test.go | 2 -- internal/repos/postgresql/repo_time_entry_test.go | 1 - internal/repos/postgresql/repo_user_test.go | 4 ---- internal/repos/postgresql/repo_work_item_comment_test.go | 3 --- internal/repos/postgresql/repo_work_item_project_demo_test.go | 1 - .../repos/postgresql/repo_work_item_project_demo_two_test.go | 1 - internal/repos/postgresql/repo_work_item_tag_test.go | 1 - internal/repos/postgresql/repo_work_item_type_test.go | 1 - internal/rest/api_user_test.go | 2 -- internal/rest/api_work_item.go | 2 +- internal/rest/api_work_item_comment_test.go | 2 -- internal/rest/api_work_item_tag_test.go | 1 - internal/rest/middleware.auth_test.go | 1 - internal/services/service_user_test.go | 2 -- internal/services/service_work_item_comment_test.go | 1 - internal/services/service_work_item_tag_test.go | 1 - 23 files changed, 1 insertion(+), 38 deletions(-) diff --git a/bin/templates/crud-api-tests.go.tmpl.bash b/bin/templates/crud-api-tests.go.tmpl.bash index 028b608f9..82290a8bf 100644 --- a/bin/templates/crud-api-tests.go.tmpl.bash +++ b/bin/templates/crud-api-tests.go.tmpl.bash @@ -56,7 +56,6 @@ $(test -n "$with_project" && echo " pj := models.ProjectNameDemo }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() ufixture := ff.CreateUser(context.Background(), servicetestutil.CreateUserParams{ @@ -217,7 +216,6 @@ done) // }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/bin/templates/crud-repo-tests.go.tmpl.bash b/bin/templates/crud-repo-tests.go.tmpl.bash index cc82db409..85279fbca 100644 --- a/bin/templates/crud-repo-tests.go.tmpl.bash +++ b/bin/templates/crud-repo-tests.go.tmpl.bash @@ -58,7 +58,6 @@ $(test -n "$with_project" && echo " projectID := internal.ProjectIDByName[models }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() @@ -112,7 +111,6 @@ func Test${pascal_name}_${delete_method}(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() @@ -154,7 +152,6 @@ func Test${pascal_name}_ByIndexedQueries(t *testing.T) { }, } for _, tc := range uniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } } diff --git a/bin/templates/crud-service-tests.go.tmpl.bash b/bin/templates/crud-service-tests.go.tmpl.bash index 01b254ca9..8eabc056e 100644 --- a/bin/templates/crud-service-tests.go.tmpl.bash +++ b/bin/templates/crud-service-tests.go.tmpl.bash @@ -82,7 +82,6 @@ done) } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/internal/codegen/codegen_test.go b/internal/codegen/codegen_test.go index 7498c96a2..06499f22a 100644 --- a/internal/codegen/codegen_test.go +++ b/internal/codegen/codegen_test.go @@ -54,7 +54,6 @@ func TestAnalyzeSpec(t *testing.T) { } for _, tc := range cases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() @@ -222,7 +221,6 @@ func (h *StrictHandlers) Bar() { // }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/internal/repos/postgresql/repo_activity_test.go b/internal/repos/postgresql/repo_activity_test.go index 010c7d16a..6685deae6 100644 --- a/internal/repos/postgresql/repo_activity_test.go +++ b/internal/repos/postgresql/repo_activity_test.go @@ -53,7 +53,6 @@ func TestActivity_ByIndexedQueries(t *testing.T) { }, } for _, tc := range uniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } @@ -68,7 +67,6 @@ func TestActivity_ByIndexedQueries(t *testing.T) { }, } for _, tc := range nonUniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } } diff --git a/internal/repos/postgresql/repo_kanban_step_test.go b/internal/repos/postgresql/repo_kanban_step_test.go index 4b60aaaf9..1ecfe698b 100644 --- a/internal/repos/postgresql/repo_kanban_step_test.go +++ b/internal/repos/postgresql/repo_kanban_step_test.go @@ -26,7 +26,6 @@ func TestKanbanStep_ByIndexedQueries(t *testing.T) { }, } for _, tc := range uniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } @@ -50,7 +49,6 @@ func TestKanbanStep_ByIndexedQueries(t *testing.T) { }, } for _, tc := range nonUniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } } diff --git a/internal/repos/postgresql/repo_project_test.go b/internal/repos/postgresql/repo_project_test.go index 08b0e3636..976d095bc 100644 --- a/internal/repos/postgresql/repo_project_test.go +++ b/internal/repos/postgresql/repo_project_test.go @@ -39,7 +39,6 @@ func TestProject_ByIndexedQueries(t *testing.T) { }, } for _, tc := range uniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } } diff --git a/internal/repos/postgresql/repo_team_test.go b/internal/repos/postgresql/repo_team_test.go index ed6bcead5..2667fe4a7 100644 --- a/internal/repos/postgresql/repo_team_test.go +++ b/internal/repos/postgresql/repo_team_test.go @@ -49,7 +49,6 @@ func TestTeam_ByIndexedQueries(t *testing.T) { }, } for _, tc := range uniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } } @@ -122,7 +121,6 @@ func TestTriggers_sync_user_teams(t *testing.T) { }, } for _, tc := range testCases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/internal/repos/postgresql/repo_time_entry_test.go b/internal/repos/postgresql/repo_time_entry_test.go index e68156066..09cee520d 100644 --- a/internal/repos/postgresql/repo_time_entry_test.go +++ b/internal/repos/postgresql/repo_time_entry_test.go @@ -34,7 +34,6 @@ func TestTimeEntry_ByIndexedQueries(t *testing.T) { }, } for _, tc := range uniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } diff --git a/internal/repos/postgresql/repo_user_test.go b/internal/repos/postgresql/repo_user_test.go index f9462a1a5..fc1f7f1a2 100644 --- a/internal/repos/postgresql/repo_user_test.go +++ b/internal/repos/postgresql/repo_user_test.go @@ -52,7 +52,6 @@ func TestUser_Update(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() @@ -109,7 +108,6 @@ func TestUser_SoftDelete(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() @@ -192,7 +190,6 @@ func TestUser_ByIndexedQueries(t *testing.T) { }, } for _, tc := range uniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } @@ -227,7 +224,6 @@ func TestUser_ByIndexedQueries(t *testing.T) { }, } for _, tc := range nonUniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } } diff --git a/internal/repos/postgresql/repo_work_item_comment_test.go b/internal/repos/postgresql/repo_work_item_comment_test.go index a903b00bc..34e3de7ec 100644 --- a/internal/repos/postgresql/repo_work_item_comment_test.go +++ b/internal/repos/postgresql/repo_work_item_comment_test.go @@ -48,7 +48,6 @@ func TestWorkItemComment_Update(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() @@ -101,7 +100,6 @@ func TestWorkItemComment_Delete(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() @@ -141,7 +139,6 @@ func TestWorkItemComment_ByIndexedQueries(t *testing.T) { }, } for _, tc := range uniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } } diff --git a/internal/repos/postgresql/repo_work_item_project_demo_test.go b/internal/repos/postgresql/repo_work_item_project_demo_test.go index 5412ba344..fa15f2a3a 100644 --- a/internal/repos/postgresql/repo_work_item_project_demo_test.go +++ b/internal/repos/postgresql/repo_work_item_project_demo_test.go @@ -46,7 +46,6 @@ func TestDemoWorkItem_Update(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/internal/repos/postgresql/repo_work_item_project_demo_two_test.go b/internal/repos/postgresql/repo_work_item_project_demo_two_test.go index 38d0d365e..098f2fa47 100644 --- a/internal/repos/postgresql/repo_work_item_project_demo_two_test.go +++ b/internal/repos/postgresql/repo_work_item_project_demo_two_test.go @@ -49,7 +49,6 @@ func TestDemoTwoWorkItem_Update(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/internal/repos/postgresql/repo_work_item_tag_test.go b/internal/repos/postgresql/repo_work_item_tag_test.go index 02c2a8992..42f1bd7d8 100644 --- a/internal/repos/postgresql/repo_work_item_tag_test.go +++ b/internal/repos/postgresql/repo_work_item_tag_test.go @@ -37,7 +37,6 @@ func TestWorkItemTag_ByIndexedQueries(t *testing.T) { }, } for _, tc := range uniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } } diff --git a/internal/repos/postgresql/repo_work_item_type_test.go b/internal/repos/postgresql/repo_work_item_type_test.go index cac0aa21c..66e378049 100644 --- a/internal/repos/postgresql/repo_work_item_type_test.go +++ b/internal/repos/postgresql/repo_work_item_type_test.go @@ -37,7 +37,6 @@ func TestWorkItemType_ByIndexedQueries(t *testing.T) { }, } for _, tc := range uniqueTestCases { - tc := tc runGenericFilterTests(t, tc) } } diff --git a/internal/rest/api_user_test.go b/internal/rest/api_user_test.go index e18d6c101..9e47913db 100644 --- a/internal/rest/api_user_test.go +++ b/internal/rest/api_user_test.go @@ -51,7 +51,6 @@ func TestHandlers_DeleteUser(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() ufixture := ff.CreateUser(context.Background(), servicetestutil.CreateUserParams{ @@ -233,7 +232,6 @@ func TestHandlers_UpdateUser(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/internal/rest/api_work_item.go b/internal/rest/api_work_item.go index 6d8040c20..267c07595 100644 --- a/internal/rest/api_work_item.go +++ b/internal/rest/api_work_item.go @@ -98,7 +98,7 @@ func (h *StrictHandlers) CreateWorkitem(c *gin.Context, request CreateWorkitemRe var resJson *CreateWorkitem201JSONResponse json.Unmarshal(rawMessage(res), &resJson) - return *resJson, nil + return resJson, nil } func (h *StrictHandlers) GetWorkItem(c *gin.Context, request GetWorkItemRequestObject) (GetWorkItemResponseObject, error) { diff --git a/internal/rest/api_work_item_comment_test.go b/internal/rest/api_work_item_comment_test.go index 5d7864135..da7f34cba 100644 --- a/internal/rest/api_work_item_comment_test.go +++ b/internal/rest/api_work_item_comment_test.go @@ -46,7 +46,6 @@ func TestHandlers_DeleteWorkItemComment(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() @@ -205,7 +204,6 @@ func TestHandlers_UpdateWorkItemComment(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/internal/rest/api_work_item_tag_test.go b/internal/rest/api_work_item_tag_test.go index a662e0f00..9dbcca844 100644 --- a/internal/rest/api_work_item_tag_test.go +++ b/internal/rest/api_work_item_tag_test.go @@ -42,7 +42,6 @@ func TestHandlers_CreateWorkItemTag(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/internal/rest/middleware.auth_test.go b/internal/rest/middleware.auth_test.go index 38372c34a..881faf718 100644 --- a/internal/rest/middleware.auth_test.go +++ b/internal/rest/middleware.auth_test.go @@ -95,7 +95,6 @@ func TestAuthorizationMiddleware(t *testing.T) { svcs := services.New(logger, services.CreateTestRepos(t), testPool) for _, tc := range testCases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() res := httptest.NewRecorder() diff --git a/internal/services/service_user_test.go b/internal/services/service_user_test.go index 3a3ac2a70..ccae4cbc0 100644 --- a/internal/services/service_user_test.go +++ b/internal/services/service_user_test.go @@ -87,7 +87,6 @@ func TestUser_UpdateUser(t *testing.T) { } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() @@ -286,7 +285,6 @@ func TestUser_UpdateUserAuthorization(t *testing.T) { } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/internal/services/service_work_item_comment_test.go b/internal/services/service_work_item_comment_test.go index cbe914aef..85a840e4f 100644 --- a/internal/services/service_work_item_comment_test.go +++ b/internal/services/service_work_item_comment_test.go @@ -54,7 +54,6 @@ func TestWorkItemComment_Update(t *testing.T) { }, } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() diff --git a/internal/services/service_work_item_tag_test.go b/internal/services/service_work_item_tag_test.go index 33083afe4..d306bdf34 100644 --- a/internal/services/service_work_item_tag_test.go +++ b/internal/services/service_work_item_tag_test.go @@ -90,7 +90,6 @@ func TestWorkItemTag_Update(t *testing.T) { } for _, tc := range tests { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel()