Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering PHP Errors isn't optional #63

Open
tornadotwins opened this issue Mar 13, 2019 · 0 comments · May be fixed by #94
Open

Triggering PHP Errors isn't optional #63

tornadotwins opened this issue Mar 13, 2019 · 0 comments · May be fixed by #94

Comments

@tornadotwins
Copy link

First of all, great class! Thanks!
An issue I ran into:

In the release notes of v.0.8.5, it's said that "Triggering an error is now optional (on by default)".

Except, it's not.
Most functions (getSendQuota(), getSendStatistics(), verifyEmailAddress(), etc) don't have a way to overwrite triggering errors, nor do these functions look at $this->__trigger_errors set by the constructor.

So, even if you turn triggering errors off in the constructor, most functions ignore it and trigger errors anyway.

The only function that lets us overwrite it is sendEmail().

This makes it difficult to check if the user has entered valid auth keys, without PHP going into fatal errors.

xJuvi added a commit to xJuvi/php-aws-ses that referenced this issue Aug 5, 2022
@xJuvi xJuvi linked a pull request Aug 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant