Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML validity and accessibility issues #23

Open
Youhan opened this issue Feb 12, 2024 · 1 comment
Open

HTML validity and accessibility issues #23

Youhan opened this issue Feb 12, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@Youhan
Copy link

Youhan commented Feb 12, 2024

I can spot some issues regarding the validity of HTML (like putting div inside span, or form inside h1) and also there is room for adding aria-* for better accessibility.

Are you planning on a new design? If that's the case there will be huge changes on the markup I assume. That's why I am hesitating to fix the markup and accessibility cause that would cause HTML markup changes too.

What do you suggest? I can also contribute to implementing the new design and do the validity/accessibility stuff along the way.

@maige-app maige-app bot added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Feb 12, 2024
@danielroe
Copy link
Owner

Thanks for spotting! Implemented some fixes for the HTML validation issues and added a module to ensure it doesn't happen again: 28f1715.

A new design might well be on the cards ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants