Redefine default test location for leapp-repository #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmyway
force-pushed
the
resolve-default-repo-for-leapp-tests
branch
from
aea6303 to
f6bb89f
Compare
* without `-g/--git` the script was resolving the default test repository url poorly, user forced to specify as commandline option * additionally user was unable to select a branch/git reference when specifying the leapp-tests location on the commandline * with the fix the default leapp-tests repository is defined without the git argument needed * make git option accept four args - baseurl, repo owner, repo name and git branch/reference to checkout * add simple test covering the git argument * resolves 37 * additional changes made by pre-commit hook Signed-off-by: Daniel Diblik <[email protected]>
danmyway
force-pushed
the
resolve-default-repo-for-leapp-tests
branch
from
f6bb89f to
94d2567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-g/--gitthe script was resolving the default test repository url poorly, user forced to specify as commandline option