From 79591ebf331c1e764a94527fa308db883acd5497 Mon Sep 17 00:00:00 2001 From: teodorus-nathaniel Date: Thu, 12 Sep 2024 00:15:34 +0700 Subject: [PATCH 1/4] Fix wrong wording --- src/modules/telegram/channels/ChannelContentPage/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/telegram/channels/ChannelContentPage/index.tsx b/src/modules/telegram/channels/ChannelContentPage/index.tsx index 4901a0083..9a74d9386 100644 --- a/src/modules/telegram/channels/ChannelContentPage/index.tsx +++ b/src/modules/telegram/channels/ChannelContentPage/index.tsx @@ -316,7 +316,7 @@ function ContestInfo({ : 'Points'} - Winners + Rewards pool ) From 925ccb07e994df068a56d7d5f17cf8b0254a388c Mon Sep 17 00:00:00 2001 From: teodorus-nathaniel Date: Thu, 12 Sep 2024 22:06:12 +0700 Subject: [PATCH 2/4] Add loading skeleton for contest winners --- .../HomePage/HomePageContestPreview.tsx | 26 ++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/src/modules/telegram/HomePage/HomePageContestPreview.tsx b/src/modules/telegram/HomePage/HomePageContestPreview.tsx index 512214a24..5918806a5 100644 --- a/src/modules/telegram/HomePage/HomePageContestPreview.tsx +++ b/src/modules/telegram/HomePage/HomePageContestPreview.tsx @@ -2,13 +2,16 @@ import AddressAvatar from '@/components/AddressAvatar' import Button from '@/components/Button' import LinkText from '@/components/LinkText' import Name from '@/components/Name' +import { Skeleton } from '@/components/SkeletonFallback' import { getReferralLeaderboardQuery } from '@/services/datahub/referral/query' import { isDef } from '@subsocial/utils' import { useState } from 'react' import LeaderboardModal from '../FriendsPage/LeaderboardModal' const HomePageContestPreview = () => { - const { data: referrersData } = getReferralLeaderboardQuery(true).useQuery({}) + const { data: referrersData, isLoading } = getReferralLeaderboardQuery( + true + ).useQuery({}) const [isOpen, setIsOpen] = useState(false) const { leaderboardData: items } = referrersData || {} @@ -25,6 +28,10 @@ const HomePageContestPreview = () => {
+ {isLoading && + Array.from({ length: 3 }).map((_, idx) => ( + + ))} {data.map((item, index) => { if (!item) return null @@ -79,4 +86,21 @@ const ContestPreviewItem = ({ item, withDivider }: ContestPreviewItemProps) => { ) } +const ContestPreviewItemSkeleton = () => { + return ( +
+
+
+ +
+ + +
+
+ +
+
+ ) +} + export default HomePageContestPreview From df8324fda3e2695b0015980e3443f497d2fe76bd Mon Sep 17 00:00:00 2001 From: teodorus-nathaniel Date: Thu, 12 Sep 2024 22:12:12 +0700 Subject: [PATCH 3/4] Adjust margin for skeleton --- .../HomePage/HomePageContestPreview.tsx | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/modules/telegram/HomePage/HomePageContestPreview.tsx b/src/modules/telegram/HomePage/HomePageContestPreview.tsx index 5918806a5..a6c36d2af 100644 --- a/src/modules/telegram/HomePage/HomePageContestPreview.tsx +++ b/src/modules/telegram/HomePage/HomePageContestPreview.tsx @@ -28,21 +28,21 @@ const HomePageContestPreview = () => {
- {isLoading && - Array.from({ length: 3 }).map((_, idx) => ( - - ))} - {data.map((item, index) => { - if (!item) return null + {isLoading + ? Array.from({ length: 3 }).map((_, idx) => ( + + )) + : data.map((item, index) => { + if (!item) return null - return ( - - ) - })} + return ( + + ) + })}
)} diff --git a/src/modules/telegram/HomePage/MemesPreview.tsx b/src/modules/telegram/HomePage/MemesPreview.tsx index 1f7e21f39..b694fe314 100644 --- a/src/modules/telegram/HomePage/MemesPreview.tsx +++ b/src/modules/telegram/HomePage/MemesPreview.tsx @@ -126,7 +126,11 @@ export const MemesPreviewItem = ({ return ( )