Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing resume and pause Methods in DaprWorkflowClient #659

Open
tonyyangskand opened this issue Feb 11, 2025 · 0 comments
Open

Missing resume and pause Methods in DaprWorkflowClient #659

tonyyangskand opened this issue Feb 11, 2025 · 0 comments

Comments

@tonyyangskand
Copy link

Describe the proposal

Description:
I noticed that DaprWorkflowClient in the Dapr JS SDK does not implement resume and pause functionalities:
🔗 [DaprWorkflowClient.ts](https://github.com/dapr/js-sdk/blob/main/src/workflow/client/DaprWorkflowClient.ts)

However, the underlying library, durabletask-js, does support these operations:
🔗 [durabletask-js Client.ts](https://github.com/microsoft/durabletask-js/blob/020325269fcd2c8b0909e5598ec4fae935d196b0/src/client/client.ts#L259)

Feature Mapping

Here's a comparison of available methods:

durabletask-js DaprWorkflowClient
stop() stop()
scheduleNewOrchestration() scheduleNewWorkflow()
getOrchestrationState() getWorkflowState()
waitForOrchestrationStart() waitForWorkflowStart()
waitForOrchestrationCompletion() waitForWorkflowCompletion()
raiseOrchestrationEvent() raiseEvent()
terminateOrchestration() terminateWorkflow()
purgeOrchestration() purgeWorkflow()

Missing Methods in DaprWorkflowClient:

  • suspendOrchestration() (Pause)
  • resumeOrchestration() (Resume)

Request for Clarification

Is there a specific reason why these two methods (suspendOrchestration and resumeOrchestration) have not been implemented in DaprWorkflowClient? If this is an oversight, would it be possible to add support for them in a future release?

Thanks for your time and consideration! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant