-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster dev cycle #3800
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks @tenhobi, thanks @rrousselGit. I'm going to start marking comments I've replied to on this thread as "resolved" to keep it focused, since lots of people are watching it :) but I do appreciate the input. Caching can certainly help, but it doesn't address the underlying problems, which are 1) performance, 2) granularity of invalidation. I've created a sub-issue #3810 for granular invalidation, Remi I'll reply to your question there :) I've also moved performance to a sub-issue #3811 so we can use this issue for overarching things. |
This comment has been minimized.
This comment has been minimized.
For anyone who wants to follow PR by PR, they will be on the sub-issue for scalable performance #3811 for now :) |
This comment has been minimized.
This comment has been minimized.
The fastest proof of concept I have so far is about 6x faster on 1000 files, 120s incremental build -> 20s incremental build. But I'm still laying the groundwork to make that landable, as I said, it's complicated :) The benchmark right now at commit
which at 120s->94s is only 1.25x faster ;) The code I'm merging is not actually live, needs |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@gmpassos thanks! I've created a discussion for people who want to try and give feedback on the work-in-progress performance changes, I'll reply there. |
I've been digging into
build_runner
performance, and in particular, scalability of analyzer-based generators as the codebase grows.It looks like there is room for significant improvement, so that's good :)
It's complicated, so I will need to move carefully with details discussed as I go.
First job will be to add some benchmarks #1335.
The text was updated successfully, but these errors were encountered: