Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "skipped" results from current_results database #107

Open
whesse opened this issue Mar 24, 2021 · 0 comments
Open

Remove "skipped" results from current_results database #107

whesse opened this issue Mar 24, 2021 · 0 comments
Assignees
@whesse
Labels
current results ui Issues about the current results UI P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@whesse
Copy link
Contributor

whesse commented Mar 24, 2021

On the first build where a previously appearing test is not run, we put a record into results.json for that test, with current status "skipped". On later builds, that record does not appear.

We should ignore these records when updating the current results service database. They currently appear in the current results UI.
@whesse whesse added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P1 A high priority bug; for example, a single project is unusable or has many test failures labels Mar 24, 2021
@whesse whesse self-assigned this Mar 24, 2021
@whesse whesse added P3 A lower priority bug or feature request and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Sep 8, 2023
@whesse whesse added the current results ui Issues about the current results UI label Sep 19, 2023
copybara-service bot pushed a commit that referenced this issue Dec 5, 2023
@whesse
[current results] Do not store skipped tests in current results database
e810462 
When a test is skipped on a configuration for the first time,
the change is reported as a changed result with new result "skipped".
Subsequent builder runs remove this skipped record completely.
Ignore these test results in the current results server.

Bug: #107
Change-Id: I8587aab909fd367edc642f4a97513ca1a39e0592
Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/339921
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
current results ui Issues about the current results UI P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whesse