Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results feed should say "(changed expectation Pass)" when an expectation changes #119

Open
whesse opened this issue Sep 29, 2021 · 0 comments
Labels
results feed Issues about the results feed UI type-enhancement A request for a change that isn't a bug

Comments

@whesse
Copy link
Contributor

whesse commented Sep 29, 2021

The results processing has just been changed to report tests where the result stays the same, but the expected result changes due to a commit, as changed.

Right now, they will show up as new passes or new failures in the results feed, depending on whether the result matches the new expectation or not. But the description of the change will say, for example (if the expectation changes from Pass to CompileTimeError):
Pass -> Pass (expected CompileTimeError).

We can make this say instead
Pass -> Pass (changed expectation CompileTimeError)
by detecting that the previous result and new result are the same - that only happens when an expectation changes.

We do not save the old expectation in the results records, so there is no easy way to show what the expectation was changed from.

@athomas

@whesse whesse added the type-enhancement A request for a change that isn't a bug label Sep 29, 2021
@whesse whesse added the results feed Issues about the results feed UI label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
results feed Issues about the results feed UI type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant