Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approval messages in current results feed are not connected to test but to commit range? #149

Open
dcharkes opened this issue Jul 6, 2023 · 1 comment
Labels
results feed Issues about the results feed UI

Comments

@dcharkes
Copy link

dcharkes commented Jul 6, 2023

When going to the history of a test, all kinds of comments show up that are not related to that test but to other test status approvals that happened to be in the same commit range.

My hunch is that when a range of commits has multiple test failures, and then someone goes in and approves with comment each test failure individually, the comments are not tied to the specific test status change, but to the commit range. And that when showing a test history, all the comments on the commit range are shown for each commit range that has status changes for that test.

This makes it harder to reapprove tests that are meta-flaking, as there are a bunch of different referenced issues in the test history instead of just one.

Example: https://dart-ci.web.app/#showLatestFailures=false&test=co19/LibTest/io/WebSocket/closeCode_A01_t02&configurations=vm-win-release-ia32

Screenshot 2023-07-06 at 09 28 11
@dcharkes
Copy link
Author

dcharkes commented Jul 6, 2023

Also, when doing another approval on the same commit range, it shows the message of the previous approval.

Screenshot 2023-07-06 at 09 36 08

@whesse whesse added the results feed Issues about the results feed UI label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
results feed Issues about the results feed UI
Projects
None yet
Development

No branches or pull requests

2 participants