You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When going to the history of a test, all kinds of comments show up that are not related to that test but to other test status approvals that happened to be in the same commit range.
My hunch is that when a range of commits has multiple test failures, and then someone goes in and approves with comment each test failure individually, the comments are not tied to the specific test status change, but to the commit range. And that when showing a test history, all the comments on the commit range are shown for each commit range that has status changes for that test.
This makes it harder to reapprove tests that are meta-flaking, as there are a bunch of different referenced issues in the test history instead of just one.
When going to the history of a test, all kinds of comments show up that are not related to that test but to other test status approvals that happened to be in the same commit range.
My hunch is that when a range of commits has multiple test failures, and then someone goes in and approves with comment each test failure individually, the comments are not tied to the specific test status change, but to the commit range. And that when showing a test history, all the comments on the commit range are shown for each commit range that has status changes for that test.
This makes it harder to reapprove tests that are meta-flaking, as there are a bunch of different referenced issues in the test history instead of just one.
Example: https://dart-ci.web.app/#showLatestFailures=false&test=co19/LibTest/io/WebSocket/closeCode_A01_t02&configurations=vm-win-release-ia32
The text was updated successfully, but these errors were encountered: