Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acessing ResolvedLibraryResult inside MultiCorrectionProducer #57092

Closed
FMorschel opened this issue Nov 14, 2024 · 3 comments
Closed

Acessing ResolvedLibraryResult inside MultiCorrectionProducer #57092

FMorschel opened this issue Nov 14, 2024 · 3 comments
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-enhancement A request for a change that isn't a bug

Comments

@FMorschel
Copy link
Contributor

For https://dart-review.googlesource.com/c/sdk/+/386020 (#56830), I need access to ResolvedLibraryResult for walking up the part files and getting all ImportDirectives. Similar to what was done for Go to Import at https://dart-review.googlesource.com/c/sdk/+/394200.

I'll open a Cl for adding this to MultiCorrectionProducer and link it here.
@dart-github-bot
Copy link
Collaborator

Summary: The user needs access to ResolvedLibraryResult within MultiCorrectionProducer to walk up part files and retrieve all ImportDirectives, similar to the implementation in Go to Import. They will create a CL to add this functionality and link it to the issue.

@dart-github-bot dart-github-bot added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-enhancement A request for a change that isn't a bug labels Nov 14, 2024
@FMorschel
Copy link
Contributor Author

https://dart-review.googlesource.com/c/sdk/+/395420

@devoncarew devoncarew removed the triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. label Nov 15, 2024
@FMorschel
Copy link
Contributor Author

I've added you, @bwilkerson, as a reviewer there, can you please review this? There are lots of files on this CL with small changes but this weekend I had to fix merge conflicts twice on the same day already 😅 (because of the big file count). scheglov has already guided me through this change, reviewed everything and approved it. Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@devoncarew @FMorschel @dart-github-bot