Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad add required argument #59950

Open
stephane-archer opened this issue Jan 22, 2025 · 2 comments
Open

bad add required argument #59950

stephane-archer opened this issue Jan 22, 2025 · 2 comments
Labels
analyzer-quick-fix analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on

Comments

@stephane-archer
Copy link

Image Image Image

input code:

    final AsyncValue<LutFoldersState> lutFoldersStateAsyncValue =
        ref.watch(lutFoldersProvider);
    return lutFoldersStateAsyncValue.when<Widget>();

output code:

    final AsyncValue<LutFoldersState> lutFoldersStateAsyncValue =
        ref.watch(lutFoldersProvider);
    return lutFoldersStateAsyncValue.when<Widget>(data: (T data) {  });

expected code:

    final AsyncValue<LutFoldersState> lutFoldersStateAsyncValue =
        ref.watch(lutFoldersProvider);
    return lutFoldersStateAsyncValue.when<Widget>(data: (LutFoldersState data) {  });
@stephane-archer stephane-archer added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jan 22, 2025
@lrhn
Copy link
Member

lrhn commented Jan 22, 2025

Not having a type at all, so inserting data : (data) { }, would avoid inserting the wrong type, and would be "more idiomatic".
(Unless there is an enabled lint telling you to write all the types, then the fix should satisfy the lint, not generate something you need a second fix for.)

@stephane-archer
Copy link
Author

@lrhn Removing the type is also a solution. Right now removing T manually or replacing it manually is annoying.

@bwilkerson bwilkerson added analyzer-server analyzer-quick-fix P2 A bug or feature request we're likely to work on labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-quick-fix analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

3 participants