Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block height support in rpc call getblock #2517

Open
salisbury-espinosa opened this issue Dec 2, 2018 · 3 comments
Open

Add block height support in rpc call getblock #2517

salisbury-espinosa opened this issue Dec 2, 2018 · 3 comments

Comments

@salisbury-espinosa
Copy link

feature request: RPC getblock accepts height or hash
in the upstream there are 2 unaccepted PR:
https://github.com/bitcoin/bitcoin/pull/8457/files
and duplicate https://github.com/bitcoin/bitcoin/pull/14858/files
Rejection argument: bitcoin#8457 (comment)
Is there a place for these changes in dash?

@UdjinM6
Copy link

UdjinM6 commented Dec 3, 2018

This could be helpful probably but I agree with reasons provided for not merging it, at least for an overloaded version. If anything I would rather see smth like this implemented as a separate rpc (e.g. getblockbyheight as suggested in one of the comments) which would clearly state in its help text that this rpc returns a block in best-block-chain at height provided (as in getblockhash) meaning that results can change if there is a reorg later.

@dashuser33
Copy link

As someone working with the RPC, plus one on not overloading existing commands. A new command is way better.

@PastaPastaPasta
Copy link
Member

btw: there is an implementation here bitcoin#16345 of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants