Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dat Ecosystem web component #68

Closed
16 tasks done
Tracked by #37
Hornet004 opened this issue Nov 30, 2022 · 7 comments
Closed
16 tasks done
Tracked by #37

Dat Ecosystem web component #68

Hornet004 opened this issue Nov 30, 2022 · 7 comments

Comments

@Hornet004
Copy link

Hornet004 commented Nov 30, 2022

#37

@todo


  • Split- Dat ecosystem page into version-controlled component style (v0.0.1)

@Hornet004
Copy link
Author

Hornet004 commented Nov 30, 2022

tasks

  • Organization
    • went through feedbacks on discord feedbacks - 31min
    • meet with Toshi for an GitHub comment explanation - 20min
    • Create and Edit new issue - 29min
    • Scheduled another meeting with Toshi for GitHub comment explanation - 50min
    • Create a video explanation and upload - 15min
    • Reupdate issue - 30min

feedbacks

  • Read and watched all feedback from discord and still didn't understand them and had to schedule a meeting with toshi, then created a new issue
  • Also updated the issue

worklogs


proposals


@serapath
Copy link
Member

serapath commented Dec 2, 2022

feedback 2022.12.02

thx. i edited minor things, e.g. @Output to @output and in the top level comment, i changed the input of the Organization task to toshi's "Task Management Playlist", because that seems more accurate than using the figma file as input, which is not really related to any of the github issue structuring.

otherwise, everything is spot on, so again thank you for pushing through - it might not seem a lot and it takes some time, but in the long run having all issues done accurately in this style is valuable for us to not get lost in details. Looking forward to the next worklog and I guess that's when @ninabreznik will mainly give feedback, because this time my job is just to make sure we are staying organized with our task management

@Hornet004
Copy link
Author

Hornet004 commented Dec 3, 2022

tasks

  • Split- Dat ecosystem page into version-controlled component style (v0.0.1)

feedbacks

  • Splitted the components for an overview so Nina and I could discuss them and the direction

worklogs


proposals


@ninabreznik
Copy link
Member

ninabreznik commented Dec 3, 2022

@Hornet004
Copy link
Author

tasks


feedbacks

  • Got feedback from Nina and worked on each component.

worklogs


proposals


@ninabreznik
Copy link
Member

Looks good. As I said, we will adjust the components as we go, that is why we now have this versioning system.

So, little feedback:

  • header and growth-program-card components have the component presented twice (once with the title, version and dependencies and once without, so let's remove the ones without)
  • mobile popup doesn't have the title, version and dependencies

So, let's now start with the first component. maybe an icon with the text or a button?

@Hornet004
Copy link
Author

tasks


feedbacks

  • built text wiht image component

worklogs


proposals


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants